Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text not updating when resolution or dropShadow changes #10577

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 23, 2024

fixes: #10439

  • fixes text resolution not invalidating style key when changed, so the text never updates to the new resolution
  • fixes dropShadow not being able to be updated like this text.style.dropShaow.angle += 1, previously you would have to set the whole object again

Copy link

codesandbox-ci bot commented May 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 424f0d5:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title fix: text not updating when resolution or style changes fix: text not updating when resolution or dropShadow changes May 23, 2024
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 24, 2024
@Zyie Zyie added this pull request to the merge queue May 24, 2024
@Zyie Zyie removed this pull request from the merge queue due to a manual request May 24, 2024
@Zyie Zyie added this pull request to the merge queue May 27, 2024
Merged via the queue into dev with commit 55d262d May 27, 2024
5 checks passed
@Zyie Zyie deleted the fix/text-updates branch May 27, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Some props like dropShadow and resolution are not updating for Text object.
2 participants