BaseTexture updates and timing fixes #1193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes obscure image-load timing issues. This can be caused because `Image.complete` is not synchronouse with respect to script execution. - http://www.w3.org/TR/html5/embedded-content-0.html#the-img-element - pixijs#1165 - Fixed `updateSourceImage` so it will correctly run through the loading process again, as if specified as the original source. - DOM events are removed once they are done being useful. - Added `isLoading` so that a non-async never-going-to-load can be detected. - Updated documentation to account for accepting a Canvas and the default values applied, the behavior of `loadSource` and the 'loaded' and 'error' events.
- Additional documentation updates/corrections - Data URI detection now requires the URI starts-with data: and does not detect the case where another URL may containg data:
|
👍 I will merge this in to the rewrite branch shortly (see: #1296). |
|
This totally should've been merged a long time ago, thanks for all the hard work @pnstickne! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue in #1165 but does not delay the
srcassignment and thus the immediately-ready path is still available. Also addresses a few other edge cases and adds/updates relevant documentation.Image.completeis not synchronouse with respect to script execution.updateSourceImageso it will correctly run through the loadingprocess again, as if specified as the original source.
isLoadingso that a non-async never-going-to-load can bedetected.
values applied, the behavior of
loadSourceand the 'loaded' and'error' events.