Filter out prototype properties

[johnste]

Make sure to filter out properties from the prototype. Currently pixi.js doesn't work with ember.js due to this.

[drkibitz]

I haven't seen this code yet, but since you brought it to attention, listeners[ event.type ] is an array. So it's safer just to...

for(var i = 0, l = listeners[ event.type ].length; i < l; i++)

There's a few other optimizations I may do in this file, in another pull request. Backbone.Events is a great model to follow for performance, across most, if not all modern platforms. I recently ported it to a proprietary engine pretty easily.

[johnste]

Yeah, you're right of course. I'll update the pull request.

[englercj]

👍 Sorry it took so long to get around to this, it looks good. I appreciate you following the code style in this file (even though it looks ridiculous).

Although the if ( typeof listeners[ event.type ] !== 'function' ) { check is incorrect, and unnecessary if you are using a proper for loop. If .length is undefined then the loop condition will fail, and filter prototype properties implicitly.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.