Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IE11 check. IE11 no longer has MSIE in the userAgent, you need to ... #442

Merged
merged 1 commit into from
Dec 13, 2013

Conversation

photonstorm
Copy link
Collaborator

...check for Trident/7.0 instead.

@englercj
Copy link
Member

Haha, I just had to fix something at work for this. Good catch!

englercj added a commit that referenced this pull request Dec 13, 2013
Fixed IE11 check. IE11 no longer has MSIE in the userAgent, you need to ...
@englercj englercj merged commit 5794c68 into pixijs:dev Dec 13, 2013
@tleunen
Copy link

tleunen commented Dec 15, 2013

What is that? Don't we want IE11 to use WebGL?
If we change the way to test IE11, we need to change the way we assign it to webgl as well.

Before, we were testing ie lower than 11. Now we're testing IE11 (this specific version), but we kept the same assignation webgl = !ie.. Because of that, IE11 will use the CanvasRenderer instead of WebGL :/

But my main concern is, do we really need to check IE specific version?

@englercj
Copy link
Member

WebGL is only available in IE11, so the check was always for IE11 (it was just wrong). Until we make the renderer compatible with IE11's webgl, we disable it.

@tleunen
Copy link

tleunen commented Dec 15, 2013

What's the issue with the WebGL renderer with IE11 ? I tested some demos and they are working fine. Same thing with a different project

@GoodBoyDigital
Copy link
Member

Hey guys, the webGL renderer works fine in most cases in IE11. The only issue I have found is that masking does not work correctly. This is to do with the fact that the IE11 implementation of gl.colorMask ignores the alpha channel and always sets it to true :(

I'm sure I can use a shader to get around that for ie11 though so that it masks a little differently.

@photonstorm
Copy link
Collaborator Author

If it mostly works in IE11 then the check ought to be removed entirely, as it's redundant. As it stood before I changed it, it didn't "fix" for IE11 at all, it just said 'no webgl' for a browser that never had it anyway.

@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants