Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for the forceCanvas option #5468

Merged
merged 2 commits into from Feb 22, 2019

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Feb 22, 2019

It seems this option is only available in pixi.js-legacy, and you can't use forceCanvas with pixi.js anymore. The docs should state that.

It seems this option is only available in pixi.js-legacy, and it
seems you can't use forceCanvas with pixi.js anymore. The docs should
state that.

* pixijs#5417
* pixijs#5389
@themoonrat
Copy link
Member

I almost wonder if for this option it should output a console error message as well.... otherwise I can see so make incoming questions about this option not working...

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a necessary addition, but we have some bigger problems about how to communicate things that are legacy bundle. Most recently this came up recently here #5461 and #5389. I would love to see a larger docs PR that addresses these as well.

@bigtimebuddy bigtimebuddy merged commit eb57e0a into pixijs:dev Feb 22, 2019
@lock
Copy link

lock bot commented Feb 23, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants