Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly deprecate BaseTexture v4 members and methods #5556

Merged
merged 2 commits into from Apr 2, 2019
Merged

Properly deprecate BaseTexture v4 members and methods #5556

merged 2 commits into from Apr 2, 2019

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Mar 31, 2019 •
edited

Removes the need for migration guide step for BaseTexture's loadSource by providing a suitable workaround via deprecation.

Edit:
Also, deprecates imageUrl and hasLoaded.

cc @Adam13531

@bigtimebuddy bigtimebuddy added this to the v5.0.0 milestone Mar 31, 2019
@bigtimebuddy bigtimebuddy changed the title Properly deprecate BaseTexture's loadSource Properly deprecate BaseTexture v4 members and methods Apr 1, 2019
@bigtimebuddy bigtimebuddy merged commit 15c4ec3 into dev Apr 2, 2019
@bigtimebuddy bigtimebuddy deleted the deprecate-load-source branch April 2, 2019 18:02
@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@themoonrat themoonrat themoonrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigtimebuddy @ivanpopelyshev @themoonrat