-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for structs in shader uniforms #6298
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6298 +/- ##
=========================================
- Coverage 78.33% 77.23% -1.1%
=========================================
Files 57 178 +121
Lines 2820 9511 +6691
=========================================
+ Hits 2209 7346 +5137
- Misses 611 2165 +1554
Continue to review full report at Codecov.
|
this is really cool! |
:) What do you other guys think, could we add this to next pixi version? |
I have no problem with this feature. There are some conflicts because we just finished the TypeScript convert of core, and @GoodBoyDigital has a PR right now that will also conflict. If you can have a little patience, we can work on getting this in. |
Yep, lets merge it after @GoodBoyDigital PR. |
Cool, should I try to resolve these conflicts or should I just leave it as is? |
I resolved the conflicts, so it should be ready now :) |
Thank you @jnsmalm 🎉 |
Description of change
With this change we can set structs in shader uniforms the same way we can set it using WebGL directly.
Pre-Merge Checklist
npm run lint
)npm run test
)