-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts settings to TypeScript #6315
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6315 +/- ##
=======================================
Coverage 77.24% 77.24%
=======================================
Files 178 178
Lines 9511 9511
=======================================
Hits 7347 7347
Misses 2164 2164
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. I'm not in love with the name PixiSettings
, maybe simply Settings
? We have bigger fish than settings. Lets get this in and we can try other approaches later.
I've updated the name |
@bigtimebuddy @Zyie What about For example, it doesnt have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve it anyway, because I can change RenderOptions in @pixi/core
PR.
Would it be a good idea to have a naming convention for interfaces. So all begin with I? That way we dont have a mashup of different names. For example we have IPoint, IDestoryOptions, but DecomposedDataUri, Settings, RenderOptions
Ah yes i didnt realise that got added dynamically in |
I think |
I like using |
Ok I've updated the names to use the prefix. I'll let @ivanpopelyshev fix whatever needs to be fixed in his core pr |
Description of change
Opening another draft PR to let people know what is being worked on.
So far I have tried to use namespaces for settings however this resulted in many setting objects instead of one large one, not sure why.
For now I have gone with one interface that has optional parameters for the options defined outside the initial settings file.
Let me know if you guys have a better solution to try out. I dont think the current method is bad just not great.
Pre-Merge Checklist
npm run lint
)npm run test
)