Clarify boundsID #6334
Merged
Clarify boundsID #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpopelyshev
force-pushed
the
dev-bounds-again
branch
from
f64aeef
to
51b3f48
Compare
GoodBoyDigital
approved these changes
Jan 16, 2020
bigtimebuddy
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## dev #6334 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 186 186
Lines 10116 10116
=======================================
Hits 7887 7887
Misses 2229 2229
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is my fault that #6261 had conflicts, because I made a mistake in review. The problem appeared when we tried to merge #6304 and found that field is still used.
So, lets clear how exactly
_boundsIDis handled:DisplayObject invalidates its
_boundsID. The dependent inner object,_bounds, tracks its version, and it is being updated incalculateBounds. The tracker is stored in_bounds.updateID.No more
lastBoundsID.In future, I hope to separate global bounds from local ones and content bounds, thus I store updateID in object that contains the result - we will have multiple objects like that.
Alternatives: