Convert Graphics to typescript

[eXponenta]

Description of change

Convert PIXI.Graphics to TS

P.S Awaits before core's problems will be resolved.

cross-package changes:

type IShape = Circle | Ellipse | Polygon | Rectangle | RoundedRectangle;- moved to @pixi/math

Transform._worldID - is internal (without modificator)

changed signature of hex2rgb to:

hex2rgb(hex: number, out: Array<number> | Float32Array = []): Array<number> | Float32Array

Pre-Merge Checklist

• Tests and/or benchmarks are included
• Documentation is changed or added
• Lint process passed (npm run lint)
• Tests passed (npm run test)

[ivanpopelyshev]

It has begun.

[codecov-io]

Codecov Report

Merging #6352 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6352   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          86       86           
  Lines        4819     4819           
=======================================
  Hits         3616     3616           
  Misses       1203     1203

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965ee03...9fc888e. Read the comment docs.

[Zyie]

Looks good. Just a couple of things to discuss

[bigtimebuddy]

All the chain-able methods should return this Not Graphics, eg lineStyle method.

[eXponenta]

All the chain-able methods should return this Not Graphics, eg lineStyle method.

What you mean?

this is Graphics type.
All chain methods return this.
Chain test is passed.

Linter breaks without assignments type of return.

[Zyie]

All the chain-able methods should return this Not Graphics, eg lineStyle method.

What you mean?

He means that a method that returns the instance of the class should use this instead of Graphics.

e.g. public lineStyle(options: ILineStyleOptions | number = null): this

[eXponenta]

All the chain-able methods should return this Not Graphics, eg lineStyle method.

What you mean?

He means that a method that returns the instance of the class should use this instead of Graphics.

e.g. public lineStyle(options: ILineStyleOptions | number = null): this

Thanks, done.

[bigtimebuddy]

Why did you remove buildComplexPoly and bezierCurveTo functions?

[bigtimebuddy]

Why remove support for ...args:number[] here? These TS conversions shouldn't remove functionality. I suggest you add another argument signature for args implementation.

[eXponenta]

Same problem in Poligon package now. We doesn't support arrays in constructor now.
Can you write 2 annotation with ... and [], because i wasn't resolve this?

And we can't do this because there is lint rule as no-dupe-class-members

[eXponenta]

Oke, i restore it.
Tests will come later.

[eXponenta]

Why did you remove buildComplexPoly and bezierCurveTo functions?

Dead and doublicated code.
There aren't usage of it, and wasn't public because there no any exports.
Then buildComplexPoly is broken becouse used deaded render features, bezierCurveTo is same as BezierUtils.curveTo.

[eXponenta]

Conclusion:

• public readonly geometry can't be used because destroy method assign null to them, of course we always can do (this as any).geometry = null but what for?
• we can't create more that one method/constructor according to lint rule and some collaborators don't like this crutch ( such as me or @ivanpopelyshev )

upd. @andrewstart change lint rule, now we can do multiple annotations

upd:
public readonly geometry -> public get geometry() & private _geometry, because otherwice we can't assign null in destroy method

[bigtimebuddy]

Looks good to me!

[bigtimebuddy]

Thank you @eXponenta 🎉

[ivanpopelyshev]

@bigtimebuddy do you even sleep?

[bigtimebuddy]

@ivanpopelyshev newborn duty 👶