-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to clearing separate color and depth buffers #6358
Conversation
This reverts commit 28b5605.
Codecov Report
@@ Coverage Diff @@
## dev #6358 +/- ##
=========================================
- Coverage 77.41% 74.7% -2.71%
=========================================
Files 183 105 -78
Lines 9613 6053 -3560
=========================================
- Hits 7442 4522 -2920
+ Misses 2171 1531 -640
Continue to review full report at Codecov.
|
@amakaseev did you mean to revert? |
@bigtimebuddy I told @amakaseev in PixiJS slack that API changes are difficult to merge. He's working on better version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small doc changes, thanks for the PR. If you could provide and example demonstrating usage, that would be very helpful as well.
Co-Authored-By: Matt Karl <matt@mattkarl.com>
Co-Authored-By: Matt Karl <matt@mattkarl.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for those fixes.
Code-wise and backward compat, I’m good with this. I’ll let others comment on the utility/value of this feature.
This function required in case when autoclean canvas is disabled for optimisation reason, and I need to draw 3d model on top of 2d. I need to clean only depth buffer before 3d draw. Also it would be useful if you do not use depth buffer, and you do not have to clear it. |
@GoodBoyDigital how is it handled in your fork? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
nvm, I got it! |
Thanks for your contribution @amakaseev 🎉 |
This function required in case when autoclean canvas is disabled for optimisation reason, and I need to draw 3d model on top of 2d. I need to clean only depth buffer before 3d draw. Also it would be useful if you do not use depth buffer, and you do not have to clear it.