-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert App to TypeScript #6376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the issue with the import in TickerPlugin
Codecov Report
@@ Coverage Diff @@
## dev #6376 +/- ##
==========================================
- Coverage 74.85% 74.08% -0.78%
==========================================
Files 83 82 -1
Lines 4773 4569 -204
==========================================
- Hits 3573 3385 -188
+ Misses 1200 1184 -16 Continue to review full report at Codecov.
|
Description of change
Converts app package to TypeScript.
The main changes are:
IApplicationOptions
out ofglobal.d.ts
and now extends `IRendererOptionsAutoIApplicationPlugin
interfaceThere is a change that will need to be made once
CanvasRenderer
is converted. I've documented this with TODO's, but essentially there is some unnecessary casting happening to make TypeScript happy.Pre-Merge Checklist
npm run lint
)npm run test
)