Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert App to TypeScript #6376

Merged
merged 11 commits into from
Feb 4, 2020
Merged

Convert App to TypeScript #6376

merged 11 commits into from
Feb 4, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Feb 1, 2020

Description of change

Converts app package to TypeScript.

The main changes are:

  • Moved IApplicationOptions out of global.d.ts and now extends `IRendererOptionsAuto
  • Created IApplicationPlugin interface

There is a change that will need to be made once CanvasRenderer is converted. I've documented this with TODO's, but essentially there is some unnecessary casting happening to make TypeScript happy.

Pre-Merge Checklist
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

packages/app/src/Application.ts Outdated Show resolved Hide resolved
packages/app/src/Application.ts Outdated Show resolved Hide resolved
@bigtimebuddy bigtimebuddy added this to the v5.3.0 milestone Feb 1, 2020
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the issue with the import in TickerPlugin

@codecov-io
Copy link

codecov-io commented Feb 2, 2020

Codecov Report

Merging #6376 into dev will decrease coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6376      +/-   ##
==========================================
- Coverage   74.85%   74.08%   -0.78%     
==========================================
  Files          83       82       -1     
  Lines        4773     4569     -204     
==========================================
- Hits         3573     3385     -188     
+ Misses       1200     1184      -16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee114...c59260b. Read the comment docs.

packages/app/src/Application.ts Outdated Show resolved Hide resolved
@bigtimebuddy bigtimebuddy merged commit 584c2b2 into dev Feb 4, 2020
@bigtimebuddy bigtimebuddy deleted the dev-app-typescript branch February 4, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants