-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Extract to TypeScript #6381
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6381 +/- ##
=========================================
+ Coverage 76.7% 76.76% +0.06%
=========================================
Files 76 70 -6
Lines 4142 4028 -114
=========================================
- Hits 3177 3092 -85
+ Misses 965 936 -29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ez.
Do you think it makes sense to create a IRendererPlugin interface that Extract, Prepare, etc that they can all implement? This would basically just take renderer as a single constructor argument. Not sure if there are any other methods called by Renderer. I like hardening plugin types for users to implement to. |
I didn't think it was possible to implement an interface that defines a constructor? Could you point to an example for me. We could create a base class that plugins extend from if an interface doesn't work? |
Would probably look something like this: interface IRendererPluginConstructor {
new (renderer: Renderer): IRendererPlugin;
}
interface IRendererPlugin {
destroy(): void;
} So the Renderer here would be: static registerPlugin(pluginName: string, ctor: IRendererPluginConstructor): void |
Is this good to go, @Zyie? Was there something else you wanted to do? |
Sorry got super busy last week. Just updated this to add the So this is now good to go |
Description of change
Pre-Merge Checklist
npm run lint
)npm run test
)