Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert spritesheet to TS #6389

Merged
merged 9 commits into from
Feb 7, 2020
Merged

Convert spritesheet to TS #6389

merged 9 commits into from
Feb 7, 2020

Conversation

eXponenta
Copy link
Contributor

@eXponenta eXponenta commented Feb 6, 2020 •
edited

Awaits #6385 because LoaderResource type is required

  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy mentioned this pull request Feb 6, 2020
Closed
47 tasks
@codecov-io
Copy link

codecov-io commented Feb 7, 2020 •
edited

Codecov Report

Merging #6389 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6389   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          70       70           
  Lines        4028     4028           
=======================================
  Hits         3092     3092           
  Misses        936      936

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2f430...8753976. Read the comment docs.

@eXponenta eXponenta marked this pull request as ready for review February 7, 2020 09:59
bigtimebuddy
bigtimebuddy approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise looks good.

@ivanpopelyshev
Copy link
Collaborator

Are we adding Dict now? We survived moving core without it

@bigtimebuddy
Copy link
Member

It’s a helpful utility, it doesn’t hurt anything to add it.

@bigtimebuddy bigtimebuddy merged commit 9ed7127 into dev Feb 7, 2020
@bigtimebuddy bigtimebuddy deleted the dev-spritesheet-ts-r branch February 7, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eXponenta @codecov-io @ivanpopelyshev @bigtimebuddy @Zyie