Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mesh-extras to TypeScript #6396

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Feb 10, 2020

Description of change
Pre-Merge Checklist

Simple enough conversion.

Fixes a few types in Mesh and made data optional in Buffer.update

  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added this to the v5.3.0 milestone Feb 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #6396 into dev will increase coverage by 1.49%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6396      +/-   ##
==========================================
+ Coverage   78.37%   79.86%   +1.49%     
==========================================
  Files          64       61       -3     
  Lines        3759     3502     -257     
==========================================
- Hits         2946     2797     -149     
+ Misses        813      705     -108
Impacted Files Coverage Δ
...s/canvas/canvas-sprite/src/CanvasSpriteRenderer.js 65.51% <100%> (ø) ⬆️
packages/canvas/canvas-renderer/src/BaseTexture.js 100% <100%> (ø) ⬆️
packages/canvas/canvas-mesh/src/NineSlicePlane.js 89.36% <50%> (-1.75%) ⬇️
...nvas/canvas-graphics/src/CanvasGraphicsRenderer.js 35.51% <70%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c338451...bfd3353. Read the comment docs.

*/
constructor(vertices: IArrayBuffer, uvs: IArrayBuffer, index: IArrayBuffer)
constructor(vertices?: IArrayBuffer, uvs?: IArrayBuffer, index?: IArrayBuffer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird without default params, we had ones in v4

https://github.com/pixijs/pixi.js/blob/v4.x/src/mesh/Mesh.js#L40

However, I can justify vertices? that because PlaneGeometry uses that constructor. Its fine to set up actual data later. This version is OK, good job!

@bigtimebuddy bigtimebuddy merged commit dd14308 into dev Feb 13, 2020
@bigtimebuddy bigtimebuddy deleted the dev-mesh-extras-typescript branch February 13, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants