Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sprite-animated to TypeScript #6397

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Convert sprite-animated to TypeScript #6397

merged 2 commits into from
Feb 11, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Feb 10, 2020

Description of change

Another simple conversion.

  • Made playing a get only property to keep it readonly
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added this to the v5.3.0 milestone Feb 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #6397 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6397   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          69       69           
  Lines        3910     3910           
=======================================
  Hits         3005     3005           
  Misses        905      905

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c64c9...0e42c7e. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit 3f32ba1 into dev Feb 11, 2020
@bigtimebuddy bigtimebuddy deleted the dev-sprite-animated branch February 11, 2020 14:58
@bigtimebuddy
Copy link
Member

Thanks again @Zyie, you're killing it at the TS conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants