Fix jsdoc typings #6402
Merged
Fix jsdoc typings #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zyie
approved these changes
Feb 11, 2020
bigtimebuddy
approved these changes
Feb 11, 2020
|
@bigtimebuddy @Zyie @ivanpopelyshev I added types to signals intentionally!!. |
eXponenta
reviewed
Feb 11, 2020
| @@ -29,22 +24,6 @@ declare namespace PIXI { | |||
| destroy(): void; | |||
| } | |||
|
|
|||
| export type ICallbackID = any; | |||
There was a problem hiding this comment.
about this (all remove lines)
|
I dont understand whats wrong there, lets discuss in slack/telegram |
|
Yes, we have a problem with loader typings, but its not related to my changes. I'm gonna create separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am once again asking to approve a jsdoc fix.
@Zyie , @eXponenta made a few mistakes in conversion PRs.
I, @ivanpopelyshev , made two ANY's caused two messages that were bothering us from december.