Using 32 index buffer for large Graphics

[eXponenta]

Follow up #6047, #6104, #6107

Implementing of https://github.com/pixijs/pixi.js/wiki/v5-Hacks#pixigraphics internally.

Upd:

Introducing ContextSystem#supports to store context parameters. Could be used for store MAX_TEXTURE_UNIT and other context specific parameters.

• Documentation is changed or added
• Lint process passed (npm run lint)
• Tests passed (npm run test)

[ivanpopelyshev]

OK, in this case, I think HAS_UINT32_INDEX is good to modify.

[codecov-io]

Codecov Report

Merging #6417 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6417   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files          57       57           
  Lines        2820     2820           
=======================================
  Hits         2209     2209           
  Misses        611      611

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408ea88...2a9b337. Read the comment docs.

[GoodBoyDigital]

Totally agree, That’s a nice idea!

On Mon, 17 Feb 2020 at 23:25, Matt Karl ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/core/src/context/ContextSystem.ts <#6417 (comment)>: > + const hasuint32 + = (gl instanceof WebGL2RenderingContext) + || !!(gl as WebGLRenderingContext).getExtension('OES_element_index_uint'); + + if (!hasuint32 && settings.HAS_UINT32_INDEX) + { + /* eslint-disable max-len */ + + /* eslint-disable no-console */ + console.warn('Provided WebGL context does not support 32 index buffer, large graphics may not render correctly'); + /* eslint-enable no-console */ + + /* eslint-enable max-len */ + } + + settings.HAS_UINT32_INDEX = settings.HAS_UINT32_INDEX && hasuint32; I think we should add an env state object either to core (or a new package, or something in settings), that will be a collection of readonly properties for users that can be set from within Pixi. This would contain things like webgl/webgl2, has_uint32_index, max_textures, etc. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6417>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXX34RI67TEVR3XHC3CTPTRDMMFDANCNFSM4KWQFYDA> .

-- Sent from Gmail Mobile

[bigtimebuddy]

Much better!

One small thing: Can you make the doc @private for supports object? It’s only used internally for now, would like to not make new public APIs if we don’t need to.

[bigtimebuddy]

@eXponenta the reason to document supports as private is that it's an internal concept for now. It's always easy to make something public later, but creating a public API means that if we move or rename we need to deprecate. The supports object right now is good enough to merge this PR, but may not be the final form or where this data is stored. I don't like committing to something that isn't totally solid yet.

[bigtimebuddy]

Verification: https://jsfiddle.net/bigtimebuddy/wnqe2y7p/

[aaclayton]

I'd like to say a big thank you to everyone who worked on this (especially @eXponenta) and contributed their thoughts about how to improve the user experience here.

o7