Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making "updateText" to be public #6425

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Making "updateText" to be public #6425

merged 3 commits into from
Feb 21, 2020

Conversation

themoonrat
Copy link
Member

We often give advice to use this to force updating of the texture outside of a render cycle; for example, to generate a texture containing a piece of text which is then shared across multiple sprites.

For example
#5138 (comment)
#5043 (comment)
https://www.html5gamedevs.com/topic/42319-pixitext-caching-with-resolution/?do=findComment&comment=239720

  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

We often give advice to use this to force updating of the texture outside of a render cycle; for example, to generate a texture containing a piece of text which is then shared across multiple sprites
@bigtimebuddy bigtimebuddy added this to the v5.3.0 milestone Feb 20, 2020
@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #6425 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6425   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files          57       57           
  Lines        2820     2820           
=======================================
  Hits         2209     2209           
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff77311...0462811. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit 85c4223 into dev Feb 21, 2020
@bigtimebuddy bigtimebuddy deleted the public-updateText branch February 21, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants