-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cubemap renderTexture support #6435
Conversation
…ow to use renderTexture
91f43af
to
ccc82d9
Compare
oh! excite! will test... |
Codecov Report
@@ Coverage Diff @@
## dev #6435 +/- ##
=======================================
Coverage 78.33% 78.33%
=======================================
Files 57 57
Lines 2820 2820
=======================================
Hits 2209 2209
Misses 611 611 Continue to review full report at Codecov.
|
…texture-cubemap # Conflicts: # packages/core/src/textures/resources/ArrayResource.ts # packages/core/src/textures/resources/CubeResource.ts
I can live with this, but I'm not a huge fan of introducing another abstraction layer. I already feel classes like BaseImageResource overly complicate an otherwise simple resource system and this adds yet another layer. Is there an easier way to achieve the same thing on the resources-side? Either with some static util functions, or having CubeResource override ArrayResource methods? Also, this needed to resolve conflicts with dev. |
Hey this is cool! Thanks @ivanpopelyshev. We are going to roll this is as it adds a new useful feature 👍 We discussed and do feel that the resource manager has grown in complexity over time and would definitely benefit from a bit of a refactor, potentially using composition rather than inheritance! watch this space! |
Codecov Report
@@ Coverage Diff @@
## dev #6435 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 671 671
=========================================
Hits 671 671 Continue to review full report at Codecov.
|
Should help @GoodBoyDigital for his cases.
UPD. It works: https://www.pixiplayground.com/#/edit/4RPGjVMWfcWGyxHusdcKE