Make core independent from display

[ivanpopelyshev]

Continuation of #6443

@pixi/core can be independent from @pixi/display !

_lastObjectRendered can be null after that PR, so I patched InteractionManager too.

For now I decided that its ok to have temp parent separate for each possible detached element.

I also couldn't built pixi because of strange DisplacementFilter import, I dont know if you guys want to resolve it in one of other PR's

[bigtimebuddy]

Nice! Also, can you update the core package.json to change the dependencies?

[ivanpopelyshev]

Many times people were trying to change that thing. This PR is a delcaration that temp display object stays, but at least we can refactor it so it wont haunt us.

[codecov-io]

Codecov Report

Merging #6450 into dev will increase coverage by 1.60%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              dev    #6450      +/-   ##
==========================================
+ Coverage   78.54%   80.15%   +1.60%     
==========================================
  Files          57       57              
  Lines        2825     2827       +2     
==========================================
+ Hits         2219     2266      +47     
+ Misses        606      561      -45     

Impacted Files	Coverage Δ
packages/mixin-cache-as-bitmap/src/index.js	80.23% <0.00%> (+26.94%)	⬆️
...kages/canvas/canvas-renderer/src/CanvasRenderer.js	85.84% <100.00%> (-0.13%)	⬇️
packages/interaction/src/InteractionManager.js	94.33% <100.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd68c0b...faae01a. Read the comment docs.

[bigtimebuddy]

One other thing, can you add test(s) for these new temp functions?

[ivanpopelyshev]

I don't know which non-trivial things to add there at the moment. I prefer not to make trivial tests.

[bigtimebuddy]

You're reusing this pattern in three places, and I think we can simplify reuse:

const cacheParent = displayObject.enableTempParent();
displayObject.updateTransform();
displayObject.disableTempParent(cacheParent);

Maybe make a variant of updateTransform (safeUpdateTransform? parameter flag?) and remove enabledTempParent and disableTempParent methods.

[ivanpopelyshev]

OK, added a test.

We declined adding a parameter before because of extra if making updateTransform ugly.

no, we cant do that because there might be other operations between updateTransform and disableTempParent.

Considering all the cases where i saw temp parent is needed, and all the possible cases i know (updateColorTransform and others) it will be better if people see those lines. We cant to hide them, they are important for understanding.

[cursedcoder]

👍

[cursedcoder]

@ivanpopelyshev did you forget to push? Because I can't see any tests.

[ivanpopelyshev]

@cursedcoder https://github.com/pixijs/pixi.js/pull/6450/files#diff-b4bbad81d74f4eee9ed95ec693f53c9aR112

[ivanpopelyshev]

We have to wait for localBounds fix, then I'll go over this PR again.

[codecov-commenter]

Codecov Report

Merging #6450 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #6450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 140ca83...ae7f4d8. Read the comment docs.

[GoodBoyDigital]

👍