Move mixins to global space #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cursedcoder
reviewed
Mar 12, 2020
| @@ -0,0 +1,60 @@ | |||
| declare type InteractionTrackingData = any; | |||
|
|
|||
| declare type Cursor = 'auto' | |||
There was a problem hiding this comment.
Those particular lines were moved it from globals. They will be removed as soon as someone converts interaction to TS :)
|
I'll need to test this locally, will let you know tomorrow :) |
Zyie
approved these changes
Mar 17, 2020
|
Good one! |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is awesome.
It will lead to better integration of resource-loader and all my plugins. We'll get proper mixins declaration in
d.tsfiles!This is initial demo - I expose only DisplayObject. More stuff will be exposed later when we discuss this one.
Many mixins will be exposed for canvas packages.