return old behaviour of getLocalBounds for cacheAsBitmap and generateTexture #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6477 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 57 57
Lines 2825 2825
=======================================
Hits 2264 2264
Misses 561 561
Continue to review full report at Codecov.
|
|
Work in progress, I'm fixing stuff |
ivanpopelyshev
force-pushed
the
dev-cacheAsBitmap
branch
from
d735264
to
c508761
Compare
bigtimebuddy
approved these changes
Mar 16, 2020
ivanpopelyshev
changed the title
|
Can you port this to v4 too? |
bigtimebuddy
added a commit
that referenced
this pull request
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6365 broke cacheAsBitmap because our mixin relies on different behaviour of getLocalBounds()
The thing is, old behaviour of
getLocalBounds()can be called withgetLocalBounds(undefined, true)I wanted to make it right - work with temp parent like in renderer, and restore transform after the fact just to be sure.
But right now its easier to just patch it back.
broken: https://pixijs.io/examples/#/demos-basic/cacheAsBitmap.js
WIP: https://pixijs.io/examples/?v=dev-cacheAsBitmap#/demos-basic/cacheAsBitmap.js