Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some import @pixi/core in @pixi/core #6485

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Fix some import @pixi/core in @pixi/core #6485

merged 4 commits into from
Mar 20, 2020

Conversation

zxc122333
Copy link
Contributor

@zxc122333 zxc122333 commented Mar 20, 2020 •
edited

Description of change

Fix some import @pixi/core in @pixi/core

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codecov-io
Copy link

Codecov Report

Merging #6485 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6485   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          57       57           
  Lines        2825     2825           
=======================================
  Hits         2264     2264           
  Misses        561      561

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da8b2f...d348a2a. Read the comment docs.

bigtimebuddy
bigtimebuddy approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@zxc122333 zxc122333 mentioned this pull request Mar 20, 2020
Closed
4 tasks
@bigtimebuddy bigtimebuddy requested a review from Zyie March 20, 2020 16:15
Zyie
Zyie approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@Zyie Zyie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... my bad.

Thanks for fixing this!

@bigtimebuddy bigtimebuddy merged commit abca7a8 into pixijs:dev Mar 20, 2020
@bigtimebuddy
Copy link
Member

Thank you @zxc122333!

@zxc122333 zxc122333 deleted the fix-import-self branch March 21, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zxc122333 @codecov-io @bigtimebuddy @Zyie