-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert canvas-extract to TypeScript #6503
Conversation
I actually think your instincts were right about the GlobalMixins, however, I think we need them to define CanvasRender plugins and Renderer plugins. Currently, this is defined pretty loosely here: https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/AbstractRenderer.ts#L36-L39 That means users don't get typings for doing things like We should do this as a follow-up fix for all the plugins. |
|
@Zyie can remove CanvasExtract from the CanvasRenderer? Otherwise this is good to go |
Codecov Report
@@ Coverage Diff @@
## dev #6503 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 38 38
Lines 1903 1903
=======================================
Hits 1567 1567
Misses 336 336 Continue to review full report at Codecov.
|
I've deprecated CanvasRenderer#extract as part of this PR. This is an anti-pattern with the rest of the Renderer plugins, which hang off the |
Description of change
Nice and simple!