Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the user agent string didn't include the OS version one day, it'd default to allowMax #6603

Merged
merged 2 commits into from
May 6, 2020
Merged

If the user agent string didn't include the OS version one day, it'd default to allowMax #6603

merged 2 commits into from
May 6, 2020

Conversation

themoonrat
Copy link
Member

Switched logic, so only when we KNOW it's an old OS version do we limit the textures. In all other scenarios, allowMax
#6368

@themoonrat
If the user agent string didn't include the OS version one day, it'd …
f993516 
…default to allowMax

Switched logic, so only when we KNOW it's an old OS version do we limit the textures. In all other scenarios, allowMax
#6368
@themoonrat themoonrat added 🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. 👀 Needs Review PR needs to be reviewed by someone on the core team. labels May 5, 2020
@codecov-io
Copy link

codecov-io commented May 5, 2020 •
edited

Codecov Report

Merging #6603 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6603   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          38       38           
  Lines        1903     1903           
=======================================
  Hits         1567     1567           
  Misses        336      336

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f54560...de0e74f. Read the comment docs.

bigtimebuddy
bigtimebuddy approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@bigtimebuddy bigtimebuddy mentioned this pull request May 5, 2020
Closed
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 6, 2020
@bigtimebuddy bigtimebuddy merged commit 4590b0b into dev May 6, 2020
@bigtimebuddy bigtimebuddy deleted the maxRecommendedTextures-tweak branch May 6, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. 👀 Needs Review PR needs to be reviewed by someone on the core team. ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@themoonrat @codecov-io @ivanpopelyshev @bigtimebuddy