Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null as valid type for DisplayObject's mask #6608

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

bigtimebuddy
Copy link
Member

Fixes #6606

Clear-up typings for mask property.

Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #6608 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6608   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          38       38           
  Lines        1903     1903           
=======================================
  Hits         1567     1567           
  Misses        336      336           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf714ca...56fe92c. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit edbf2e1 into dev May 14, 2020
@bigtimebuddy bigtimebuddy deleted the bugfix/mask-type branch May 14, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIXI.Container.mask = null TypeScript error
4 participants