Introduces optional Graphics Extras Package #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpopelyshev
approved these changes
May 11, 2020
|
That was mentioned in many topics on forums and here |
themoonrat
requested changes
May 11, 2020
Codecov Report
@@ Coverage Diff @@
## dev #6613 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 38 38
Lines 1903 1903
=======================================
Hits 1567 1567
Misses 336 336 Continue to review full report at Codecov.
|
themoonrat
approved these changes
May 12, 2020
bigtimebuddy
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This introduces a new package: @pixi/graphics-extras to provide some convenience drawing functions for various shapes. Ideally this would've been the place where
drawStarwas included too.This PR was inspired by some draw experiments I did over the past year with Graphics. I thought these would be useful as a package. I added this package as opt-in (i.e., not included in the default bundles pixi.js or pixi.js-legacy).
Demos
Regular Polygon:
https://jsfiddle.net/bigtimebuddy/rqpbnj6d/
Torus:
https://jsfiddle.net/bigtimebuddy/mzq0yLv8/
Fillet and Chamfer Rectangles:
https://jsfiddle.net/bigtimebuddy/jzsgep42/
Links
Documentation
https://pixijs.download/dev-graphics-extras/packages/graphics-extras.js