Convert mixin-get-child-by-name to TS #6626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themoonrat
approved these changes
May 15, 2020
bigtimebuddy
added
the
✅ Ready To Merge
|
thank you @SerG-Y! Might you be interested in doing the other mixins? |
@bigtimebuddy yes, and also interested in converting other modules |
|
Hi 👋 this PR introduce an error in ts project : this.getChildByName is not a function |
|
@luchidalgo can you please file an issue with an example that reproduces that? |
|
Sorry it was a pixi-viewport lib error that broke pixi build :/ |
|
Okay, you should file an issue there probably? https://github.com/davidfig/pixi-viewport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Converted mixin-get-child-by-name to TS
Pre-Merge Checklist
npm run lint)npm run test)