.gitignore the package.lock.json files in the packages #6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful because Matt usually requests me to remove lockfiles when they make it into my PRs.
bigtimebuddy
approved these changes
May 19, 2020
|
That's a good call. |
Codecov Report
@@ Coverage Diff @@
## dev #6631 +/- ##
=======================================
Coverage 82.54% 82.54%
=======================================
Files 36 36
Lines 1730 1730
=======================================
Hits 1428 1428
Misses 302 302 Continue to review full report at Codecov.
|
themoonrat
approved these changes
May 20, 2020
bigtimebuddy
added
the
✅ Ready To Merge
ivanpopelyshev
approved these changes
May 22, 2020
Co-authored-by: Matt Karl <matt@mattkarl.com>
|
Sharp 👀 @bigtimebuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful because @bigtimebuddy usually requests me to remove lockfiles when they make it into my PRs.