Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert mixin-get-global-position to TS #6637

Merged
merged 3 commits into from
May 25, 2020
Merged

Convert mixin-get-global-position to TS #6637

merged 3 commits into from
May 25, 2020

Conversation

SerG-Y
Copy link
Contributor

@SerG-Y SerG-Y commented May 20, 2020

Description of change

Converted mixin-get-global-position to TS

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 22, 2020
@bigtimebuddy bigtimebuddy mentioned this pull request May 24, 2020
Closed
47 tasks
@bigtimebuddy bigtimebuddy merged commit 311d7e1 into pixijs:dev May 25, 2020
@bigtimebuddy
Copy link
Member

Thanks for all your hand @SerG-Y, it really helped us a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SerG-Y @bigtimebuddy @ivanpopelyshev