Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for graphicsUtils namespace and members #6649

Merged
merged 2 commits into from
May 28, 2020
Merged

Conversation

bigtimebuddy
Copy link
Member

Fixes #6648 - Star polygon class is part of graphicsUtils namespace not root.

Also, members of this class documented incorrectly. Fixed the names.

exports.BATCH_POOL
exports.DRAW_CALL_POOL
exports.FILL_COMMANDS

Current dev (broken)
http://pixijs.download/dev/docs/PIXI.graphicsUtils.html

This PR (fixed)
http://pixijs.download/dev-graphics-docs/docs/PIXI.graphicsUtils.html

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #6649 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6649   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          35       35           
  Lines        1724     1724           
=======================================
  Hits         1424     1424           
  Misses        300      300           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311d7e1...e243546. Read the comment docs.

packages/graphics/src/utils/index.ts Show resolved Hide resolved
packages/graphics/src/utils/index.ts Show resolved Hide resolved
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 26, 2020
@bigtimebuddy bigtimebuddy merged commit 196e197 into dev May 28, 2020
@bigtimebuddy bigtimebuddy deleted the dev-graphics-docs branch May 28, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIXI.Star returns an error on using.
4 participants