Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert polyfill package to TypeScript #6654

Merged
merged 2 commits into from
May 28, 2020
Merged

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 26, 2020

Description of change

Converts the polyfill package to TypeScript

I wasn't sure the best way to handle window.Uint32Array so i just used as any. I'm happy to update it if you guys want it changed

Other than that it was a simple enough conversion

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #6654 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6654   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          35       35           
  Lines        1724     1724           
=======================================
  Hits         1424     1424           
  Misses        300      300           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196e197...d6a5f44. Read the comment docs.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm okay with casting as any in these cases.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 26, 2020
@bigtimebuddy bigtimebuddy merged commit ccddf3f into dev May 28, 2020
@bigtimebuddy bigtimebuddy deleted the dev-typescript-polyfill branch May 28, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants