convert interaction package to TypeScript #6656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6656 +/- ##
==========================================
- Coverage 82.59% 76.84% -5.76%
==========================================
Files 35 29 -6
Lines 1724 1127 -597
==========================================
- Hits 1424 866 -558
+ Misses 300 261 -39 Continue to review full report at Codecov.
|
themoonrat
approved these changes
May 27, 2020
bigtimebuddy
approved these changes
May 27, 2020
This was referenced May 27, 2020
bigtimebuddy
added
the
✅ Ready To Merge
andrewstart
requested changes
May 27, 2020
andrewstart
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
So the previous attempt at this, #6474, seems to have stalled.
It had a few issues where it was rewriting parts of the code base so i have done a more straightforward conversion.
Didn't run into many issues so was a fairly easy conversion.
Pre-Merge Checklist
npm run lint)npm run test)