Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert canvas-display to TypeScript #6659

Merged
merged 7 commits into from
May 31, 2020
Merged

Convert canvas-display to TypeScript #6659

merged 7 commits into from
May 31, 2020

Conversation

SerG-Y
Copy link
Contributor

@SerG-Y SerG-Y commented May 27, 2020

Description of change

Converted canvas-display to TypeScript

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy mentioned this pull request May 28, 2020
Closed
47 tasks
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 28, 2020
@bigtimebuddy
Copy link
Member

@SerG-Y could you look at why this is failing?

@SerG-Y
Copy link
Contributor Author

SerG-Y commented May 31, 2020

@SerG-Y could you look at why this is failing?

Will take a look

@SerG-Y
Copy link
Contributor Author

SerG-Y commented May 31, 2020

@bigtimebuddy fixed

@bigtimebuddy bigtimebuddy merged commit 89305c5 into pixijs:dev May 31, 2020
@bigtimebuddy
Copy link
Member

Thanks for the quick turnaround @SerG-Y!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SerG-Y @bigtimebuddy @Zyie