Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert canvas graphics package to TypeScript #6663

Merged
merged 3 commits into from
May 31, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 28, 2020

Description of change

Nice and simple

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #6663 into dev will increase coverage by 8.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6663      +/-   ##
==========================================
+ Coverage   77.31%   86.04%   +8.72%     
==========================================
  Files          27       25       -2     
  Lines        1067      867     -200     
==========================================
- Hits          825      746      -79     
+ Misses        242      121     -121     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5960af7...94594da. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 28, 2020
@bigtimebuddy bigtimebuddy merged commit d4bb706 into dev May 31, 2020
@bigtimebuddy bigtimebuddy deleted the dev-typescript-canvas-graphics branch May 31, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants