Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert canvas mesh to TypeScript #6664

Merged
merged 2 commits into from
May 31, 2020
Merged

convert canvas mesh to TypeScript #6664

merged 2 commits into from
May 31, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 28, 2020

Description of change
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy mentioned this pull request May 28, 2020
Closed
47 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020 •
edited

Codecov Report

Merging #6664 into dev will increase coverage by 13.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              dev     #6664       +/-   ##
============================================
+ Coverage   86.04%   100.00%   +13.95%     
============================================
  Files          25        18        -7     
  Lines         867       690      -177     
============================================
- Hits          746       690       -56     
+ Misses        121         0      -121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bb706...5dfc0ee. Read the comment docs.

bigtimebuddy
bigtimebuddy approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy, good one

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 28, 2020
@bigtimebuddy bigtimebuddy merged commit 7f4e8fb into dev May 31, 2020
@bigtimebuddy bigtimebuddy deleted the dev-typescript-canvas-mesh branch May 31, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@themoonrat themoonrat themoonrat approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zyie @codecov-commenter @bigtimebuddy @themoonrat