Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert canvas tiling sprite to TypeScript #6665

Merged
merged 4 commits into from
May 31, 2020
Merged

convert canvas tiling sprite to TypeScript #6665

merged 4 commits into from
May 31, 2020

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 28, 2020

Description of change
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy mentioned this pull request May 28, 2020
Closed
47 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020 •
edited

Codecov Report

Merging #6665 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6665   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          678       678           
=========================================
  Hits           678       678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66d864...1790db7. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 28, 2020
@bigtimebuddy bigtimebuddy mentioned this pull request May 28, 2020
Merged
1 task
@bigtimebuddy
Copy link
Member

bigtimebuddy commented May 31, 2020 •
edited

@Zyie would you might taking a look at this? Trying to get all the canvas stuff merged in has been slow going.

@bigtimebuddy bigtimebuddy merged commit aa7e6ca into dev May 31, 2020
@bigtimebuddy bigtimebuddy deleted the dev-typescript-tiling-sprite branch May 31, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@themoonrat themoonrat themoonrat approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zyie @codecov-commenter @bigtimebuddy @themoonrat