Replace global for window in polyfill #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
added
the
🔥 High Priority
Codecov Report
@@ Coverage Diff @@
## dev #6669 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 29 29
Lines 1127 1127
=======================================
Hits 866 866
Misses 261 261 Continue to review full report at Codecov.
|
themoonrat
approved these changes
May 28, 2020
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
After updating the polyfill package to TypeScript the pixi examples page no longer works.
As discussed here pixijs/examples#66 this was due to the
commonjsrollup plugin not being compatible with TypeScript.To fix this i replaced
globalwithwindowas @bigtimebuddy suggested.This should also fix #6668
Pre-Merge Checklist
npm run lint)npm run test)