Migrated bundles to TypeScript #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
Codecov Report
@@ Coverage Diff @@
## dev #6673 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 672 672
=========================================
Hits 672 672 Continue to review full report at Codecov.
|
Zyie
approved these changes
Jun 1, 2020
themoonrat
approved these changes
Jun 2, 2020
bigtimebuddy
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the LAST of the initial TypeScript migration #6377.
We have some organizational issues with our deprecations. That file is getting very cumbersome to maintain. I suggestion we revisit this in our next major version. We should probably be making deprecations at the package level, not the bundle level, so that the typings are maintained too. I think, for now, this is sufficient. It'll be easier when we jettison these deprecations in the next major version.