Bugfix/polygon offset fix #6675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made sure it was backwards compatible too!
This reverts commit 417d99f.
this actually makes it work :) as a future update, we may wanty to set the scale property on the state. But this does the trick for now and is usable
GoodBoyDigital
added
the
🕷 Bug
Codecov Report
@@ Coverage Diff @@
## dev #6675 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 37 37
Lines 1897 1897
=======================================
Hits 1562 1562
Misses 335 335 Continue to review full report at Codecov.
|
bigtimebuddy
approved these changes
Jun 1, 2020
ShukantPal
approved these changes
Jun 1, 2020
bigtimebuddy
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tweak to how we set polygon offset.
we were setting the scale, not the offset - so nothing was happening.
a future PR we could expand state to handle the offset scale too. But it does not stop the function from working and being usable. 👍