Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interaction and accessibility namespaces #6681

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Jun 5, 2020

Recently in v5, we removed extract and prepare internal namespaces. I would also like to remove interaction and accessibility namespaces as well. These are not useful for organizing the code since they only contain a small number of classes and it simplifies the code and documentation. Internal namespacing is only really useful for utils (which would pollute the root PIXI object with lots of generic functions) and filters (which we can hang a lot more filters on with pixi-filters). It should also make it easier for users importing types in the future.

Documentation
https://pixijs.download/dev-namespace-deprecation/docs/index.html

@codecov-commenter
Copy link

Codecov Report

Merging #6681 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          672       671    -1     
=========================================
- Hits           672       671    -1     
Impacted Files Coverage Δ
bundles/pixi.js/test/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf794b6...2794533. Read the comment docs.

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants