Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize the Spritesheet format in TypeScript #6694

Merged
merged 4 commits into from
Jun 13, 2020
Merged

Formalize the Spritesheet format in TypeScript #6694

merged 4 commits into from
Jun 13, 2020

Conversation

bigtimebuddy
Copy link
Member

We should strictly define the Spritesheet format we're expecting. Remove the any references in Spritesheet.

@bigtimebuddy bigtimebuddy requested a review from Zyie June 12, 2020 18:14
andrewstart
andrewstart approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@andrewstart andrewstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah, IPointData! Outside of the scope of this PR, but we should convert many of the IPoint uses to IPointData, as many of them don't actually need the methods.

Everything in this PR looks good.

packages/spritesheet/src/Spritesheet.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020 •
edited

Codecov Report

Merging #6694 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6694   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e158d02...3531f82. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jun 12, 2020
@bigtimebuddy bigtimebuddy merged commit 7b99a4e into dev Jun 13, 2020
@bigtimebuddy bigtimebuddy deleted the dev-spritesheet-format branch June 13, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themoonrat themoonrat themoonrat approved these changes

@andrewstart andrewstart andrewstart approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bigtimebuddy @codecov-commenter @themoonrat @andrewstart @Zyie