Remove use of ts-ignore in TextFormat #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6695 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 671 671
=========================================
Hits 671 671 Continue to review full report at Codecov.
|
themoonrat
approved these changes
Jun 13, 2020
ShukantPal
approved these changes
Jun 13, 2020
bigtimebuddy
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be using
@ts-ignoreas it masks potential issues. This removes the heavy usage of this from the new TextFormat.