Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts generic string-map types to Dict typing in utils #6699

Merged
merged 2 commits into from
Jun 13, 2020

Conversation

bigtimebuddy
Copy link
Member

We have a utility for representing simple generic string-key objects called Dict, it was used in some places and not others, this harmonizes it across the code base.

{[name: string]: number}

Becomes

Dict<number>

@bigtimebuddy bigtimebuddy requested a review from Zyie June 12, 2020 19:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #6699 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb48487...d16ef18. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jun 13, 2020
@bigtimebuddy bigtimebuddy merged commit 11491b6 into dev Jun 13, 2020
@bigtimebuddy bigtimebuddy deleted the dev-dict-upgrade branch June 13, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants