Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalizes the Use of IPointData #6704

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Formalizes the Use of IPointData #6704

merged 4 commits into from
Jun 15, 2020

Conversation

bigtimebuddy
Copy link
Member

This was @andrewstart's (excellent) suggestion to use IPointData instead of IPoint, Point or ObservablePoint. This means we can use more generic objects instead of having to construct one of the Point classes. For instance:

const shapes = new PIXI.Graphics();
shapes.containsPoint({ x: 10, y: 10 });

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #6704 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5028949...206bc68. Read the comment docs.

@bigtimebuddy bigtimebuddy requested a review from Zyie June 15, 2020 16:27
@bigtimebuddy bigtimebuddy merged commit e43cfe3 into dev Jun 15, 2020
@bigtimebuddy bigtimebuddy deleted the dev-point-data branch June 15, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants