-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ESLint & TypeScript ESLint Plugins #6710
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6710 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 671 671
=========================================
Hits 671 671 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
@@ -66,7 +66,7 @@ export class ShaderSystem extends System | |||
* | |||
* @private | |||
*/ | |||
private systemCheck(): void | |||
systemCheck(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine - my only comment is here @bigtimebuddy . Why would a function be docced as private, yet not be private in typescript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s not really a concept of internal in TypeScript but if there was, this would be it. We’ve made things public even though they are only referenced externally (eg _tingRGB). This function is overridden by the unsafe-eval package so to keep from throwing a linting error it’s easier to make it public even if it never shows up in the docs. I think there’s a way we can exclude stuff like this from typings when we get there.
In summary: this is non-public API, but used by another package.
FINALLY, after all those PRs, we can now upgrade ESLint. This PR fixes a few more tiny issues and add some linting exceptions where necessary.
In general, this newer version of ESLint + plugins is much stricter and works better parsing with the latest TypeScript version. We still have a few
any
types that should get fixed eventually, but this is a big, much needed upgrade.Everything still runs: https://pixijs.io/examples/?v=dev-typescript-linting#/demos-basic/container.js