Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement render-target clear in CanvasRenderer #6712

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Implement render-target clear in CanvasRenderer #6712

merged 3 commits into from
Jun 17, 2020

Conversation

ShukantPal
Copy link
Member

@ShukantPal ShukantPal commented Jun 16, 2020 •
edited

Description of change

Implement render-target clearing in CanvasRenderer#render. This was reported in #6674.

Additional fixes:

  • Fix the default value of the clear argument in the documentation.
  • Lint process passed (npm run lint)

@ShukantPal ShukantPal requested review from a team and bigtimebuddy June 16, 2020 17:51
@bigtimebuddy
Copy link
Member

Can you just create a very simple fiddle to demo that this works?

@ShukantPal
Copy link
Member Author

@bigtimebuddy @Article19's playground https://www.pixiplayground.com/#/edit/gM7jGSOAvFhZEeJPKeGI4 now works on this branch.

Let me know if I should create something more specific.

bigtimebuddy
bigtimebuddy approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix @SukantPal 👍

ivanpopelyshev
ivanpopelyshev approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine for now.

@bigtimebuddy bigtimebuddy merged commit dea7118 into dev Jun 17, 2020
@bigtimebuddy bigtimebuddy deleted the fix/canvas-renderer-clear branch June 17, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShukantPal @bigtimebuddy @ivanpopelyshev