Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect typings in v5.3.1 #6776

Merged
merged 1 commit into from Jul 27, 2020
Merged

Fix incorrect typings in v5.3.1 #6776

merged 1 commit into from Jul 27, 2020

Conversation

bigtimebuddy
Copy link
Member

Fix #6774

@bigtimebuddy bigtimebuddy added this to the v5.3.2 milestone Jul 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2020 •
edited

Codecov Report

Merging #6776 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #6776   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa5682...961fd4a. Read the comment docs.

@ShukantPal ShukantPal self-requested a review July 26, 2020 15:11
ivanpopelyshev
ivanpopelyshev approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on pixi-tilemap, seems to work

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jul 27, 2020
@bigtimebuddy bigtimebuddy merged commit 97f08ff into main Jul 27, 2020
@bigtimebuddy bigtimebuddy deleted the hotfix-types branch July 27, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@andrewstart andrewstart andrewstart approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bigtimebuddy @codecov-commenter @ivanpopelyshev @andrewstart @ShukantPal