Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.4.x] Fix BLEND_MODES.ADD based on the commit from the 4.x branch #6972

Merged
merged 1 commit into from
Nov 2, 2020
Merged

[4.4.x] Fix BLEND_MODES.ADD based on the commit from the 4.x branch #6972

merged 1 commit into from
Nov 2, 2020

Conversation

flashist
Copy link
Contributor

@flashist flashist commented Oct 30, 2020 •
edited

Fix BLEND_MODES.ADD based on the commit: 2d50b05

Description of change
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@flashist flashist changed the title Fix BLEND_MODES.ADD based on the commit from the 4.x branch [4.4.x] Fix BLEND_MODES.ADD based on the commit from the 4.x branch Oct 30, 2020
@flashist flashist mentioned this pull request Oct 30, 2020
Closed
bigtimebuddy
bigtimebuddy approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backport of #5740. LGTM

@bigtimebuddy bigtimebuddy added this to the v4.4.5 milestone Oct 30, 2020
@flashist
Copy link
Contributor Author

Please, let me know if there is something I can help with to publish the version sooner.

@bigtimebuddy bigtimebuddy merged commit efab371 into pixijs:v4.4.x Nov 2, 2020
@flashist flashist deleted the v4.4.x branch November 3, 2020 08:19
@flashist
Copy link
Contributor Author

flashist commented Nov 3, 2020

@bigtimebuddy , could you please tell, what is the best way to be notified when the 4.4.5 version is published?

@bigtimebuddy
Copy link
Member

Sorry, I'm working on this. I haven't had a moment to push the release yet. We also moved from Travis to GitHub Actions and Travis wasn't running correctly when I tried to turn it on. I need to address that.

@bigtimebuddy
Copy link
Member

bigtimebuddy commented Nov 3, 2020 •
edited

Had to update .travis.yml on this branch to match the latest v4.x, waiting for build to finish:
https://travis-ci.org/github/pixijs/pixi.js/builds/741205674

@bigtimebuddy
Copy link
Member

That was painful, but finally got it building correctly. The issue was a bunch of Travis crap (there's a reason we removed this tool). https://travis-ci.org/github/pixijs/pixi.js/builds/741408224

Will work on a release.

@bigtimebuddy
Copy link
Member

@flashist v4.4.5 is published now.

@flashist
Copy link
Contributor Author

flashist commented Nov 6, 2020

@bigtimebuddy , thanks a lot!

@flashist flashist mentioned this pull request Nov 10, 2020
Closed
@flashist flashist mentioned this pull request Dec 10, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flashist @bigtimebuddy